search

raml-org / raml-tck

Test Compatibility Kit for RAML 1.0
http://raml-org.github.io/raml-tck/
8 stars 10 forks source link

Invalid overlay tests: cannot override node 'uses' #83

Closed evangelina closed 8 years ago

evangelina commented 8 years ago

The following tests expect no errors when they should be invalid since, according to the spec, an overlay cannot override the 'uses' node:

TCK/RAML10/Examples/raml1/overlays&extensions/overlay/slave.raml TCK/RAML10/Overlays/test025/NewOverlay2.raml TCK/RAML10/Overlays/test026/apigateway-aws-overlay.raml

ddenisenko commented 8 years ago

Overlay does not override uses node in these cases. Instead these tests demonstrate exactly the opposite: the new uses instructions in overlays, which are independent on the uses in the main file and which should also work.

Forbidding this will remove overlay's and extension's ability to use their own libraries, which is not good.

This is the case covered by the following phrase in the spec in the merging algorithm description:

All uses are resolved and applied for both Master Tree and Extension Tree. The trees MUST NOT have uses instructions with the same namespace referring to different files.