ramnathv / rMaps

Interactive Maps from R
http://rmaps.github.io
389 stars 194 forks source link

Choropleth map not showing legend or slider #55

Closed josecarlosgonz closed 10 years ago

josecarlosgonz commented 10 years ago

Hi Ramnath, rMaps is awesome! I tried to replicate adding a custom layer as shown here but I am still struggling with some issues. First, the map shows a black color fill for the State that has the maximum value (see below) Is there any way to correct it? Second, I can't make the slider to appear and allow the user to switch between years. current result

My goal is to make a map with button groups to switch between years. Here is a gist with my R, data and index.html files Thank you very much for your help!

ramnathv commented 10 years ago

The black fill appears to be due to a bug in the ichoropleth code. I use the cut function in base R to discretize the data into quantiles and I believe that the extreme values are being resolved as NA. I am in the process of a major overhaul of rMaps and will fix ichoropleth in the process.

As for the slider not appearing, it seems like you have not installed the dev branch or rCharts which has the functionality necessary to make this work. You can find the installation instructions for the dev branch of rCharts in the README for rMaps.

josecarlosgonz commented 10 years ago

OK. I installed the dev branch with the following commands since the ones in the README for rMaps didn't work (I am using Mac):

install_github(repo='rCharts',username='ramnathv',ref="dev")
install_github(repo='rMaps',username='ramnathv',ref="master")

I can see the slider now:

screenshot

Any hint on how to include the button groups? Thanks!

ramnathv commented 10 years ago

The button groups was implemented by directly manipulating the underlying HTML. You probably have an older version of devtools, which did not support the new argument conventions. Update devtools by running devtools::install_github("devtools").

josecarlosgonz commented 10 years ago

I managed to get a nice result Thanks for your help!