search

ramnes / notion-sdk-py

The official Notion API client library, but rewritten in Python! (sync + async)
https://ramnes.github.io/notion-sdk-py
MIT License
1.75k stars 138 forks source link

Implement is_full_page_or_database #198

Closed ramnes closed 1 year ago

ramnes commented 1 year ago

https://github.com/makenotion/notion-sdk-js/pull/413 port

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1691d36) 100.00% compared to head (ac786ee) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #198 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 7 7 Lines 290 294 +4 ========================================= + Hits 290 294 +4 ``` | [Impacted Files](https://app.codecov.io/gh/ramnes/notion-sdk-py/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Guillaume+Gelin) | Coverage Δ | | |---|---|---| | [notion\_client/helpers.py](https://app.codecov.io/gh/ramnes/notion-sdk-py/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Guillaume+Gelin#diff-bm90aW9uX2NsaWVudC9oZWxwZXJzLnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ramnes commented 1 year ago

@mutt0-ds I don't really like that I have to rebuild all cassettes since I don't have the same API key and parent page id as yours. Do you have any idea on how we could avoid this?

mutt0-ds commented 1 year ago

@ramnes my suggestion is that you regenerate them with a key and parent page id on your own and eventually handle the official credentials to contributors (myself included), like you have done in the PR. My test was made with a disposable account because I wanted to use cassettes locally, independently from who was running the tests.

Sure, committing all of them each time is annoying but I don't see how to bypass the issue, maybe by masking the data that changes in the yaml such as ID and time, but it will require more time and complexity than the benefit.