search

ramokz / phantom-camera

👻🎥 Control the movement and dynamically tween 2D & 3D cameras. Built for Godot 4. Inspired by Cinemachine.
https://phantom-camera.dev/
MIT License
1.97k stars 65 forks source link

Set Framed data on ready #147

Closed warent closed 7 months ago

warent commented 7 months ago

Plus some minor cleanup

ramokz commented 7 months ago

Think this is looking fine! However, I'm curious about the use cases where this is needed. Are you applying a Follow Target at runtime, via a setter method, as opposed to from the editor in your example? Mainly wondering if the fix might be a symptom of a bigger issue, which might require some more systemic changes.

warent commented 7 months ago

Think this is looking fine! However, I'm curious about the use cases where this is needed. Are you applying a Follow Target at runtime, via a setter method, as opposed to from the editor in your example? Mainly wondering if the fix might be a symptom of a bigger issue, which might require some more systemic changes.

I'm not applying any settings at runtime afaik, actually not entirely sure why this happens. May have something to do with node initialization order? Didn't really dig in that deep to check, sorry

ramokz commented 7 months ago

Am hesitant to merge a fix to a bug that cannot be easily be reproduced. I'll try and do some additional tests to figure out what might be causing the issue.

ramokz commented 7 months ago

Haven't been able to replicate the issue, as I'm still not entirely sure how to trigger it.

Would it be possible to share a simple scene, with as little or as many nodes/assets as you want, that reproduces it?

ramokz commented 7 months ago

Thanks for investigating the issue and submitting the fix! ✨