ramonhagenaars / jsons

🐍 A Python lib for (de)serializing Python objects to/from JSON
https://jsons.readthedocs.io
MIT License
289 stars 41 forks source link

#160 list deserializer propagates fork_inst #161

Closed patrickguenther closed 2 years ago

patrickguenther commented 2 years ago

resolves #160 Other container serializers/deserializers don't seem to be affected by this bug, since they seem to already handle fork_inst correctly, though I haven't tested this.

patrickguenther commented 2 years ago

Those failed checks don't seem to be my fault, are they?

ramonhagenaars commented 2 years ago

Those failed checks don't seem to be my fault, are they?

No, it seems that Python3.5 can no longer be installed with Actions on an x64 architecture... Can you maybe turn off the checks for 3.5 to see if the checks at least succeed for recent Python versions?

patrickguenther commented 2 years ago

It says, "1 workflow awaiting approval". Apparently, you have to sign off on workflow executions, for PRs from first time contributors.

codecov-commenter commented 2 years ago

Codecov Report

Merging #161 (ab5895c) into master (a5150cd) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines         1488      1488           
=========================================
  Hits          1488      1488           
Impacted Files Coverage Δ
jsons/deserializers/default_list.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5150cd...ab5895c. Read the comment docs.

ramonhagenaars commented 2 years ago

All is green now. I had to upgrade actions/setup-python to actions/setup-python@v3 in the Github Actions workflow file.

Thank you @patrickguenther , I will gladly merge and release this!