Open kloczek opened 2 years ago
With installed invoke
, lexicon
, pyyaml
and fluidity-sm
The majority of the errors are caused by a difference in the numpy version that is locked in the constraints.txt
(1.22.4) and the one you have (1.23.1); apparently numpy
marked dtype
with @final
in that new version. Would it work for you to pin numpy
to 1.22.4 until I manage to patch this?
The other error I read is the failure of this command:
/usr/bin/python3 -m invoke wheel
with
/usr/bin/python3: No module named invoke
Can you doublecheck that invoke
has been installed on /usr/bin/python3
?
Would it work for you to pin numpy to 1.22.4 until I manage to patch this?
Just checked.
[tkloczko@pers-jacek SPECS]$ grep 'BuildRequires.*python3dist(numpy)' python*
python-cairocffi.spec:#BuildRequires: python3dist(numpy)
python-cftime.spec:BuildRequires: python3dist(numpy)
python-colorspacious.spec:BuildRequires: python3dist(numpy)
python-cython.spec:BuildRequires: python3dist(numpy)
python-django.spec:BuildRequires: python3dist(numpy)
python-fsspec.spec:BuildRequires: python3dist(numpy)
python-hypothesis.spec:BuildRequires: python3dist(numpy)
python-ipykernel.spec:BuildRequires: python3dist(numpy)
python-ipyparallel.spec:BuildRequires: python3dist(numpy)
python-ipython.spec:BuildRequires: python3dist(numpy)
python-joblib.spec:BuildRequires: python3dist(numpy)
python-matplotlib.spec:BuildRequires: python3dist(numpy)
python-myst-nb.spec:BuildRequires: python3dist(numpy)
python-nb2plots.spec:#BuildRequires: python3dist(numpy)
python-nptyping.spec:BuildRequires: python3dist(numpy)
python-pandas.spec:BuildRequires: python3dist(numpy)
python-partd.spec:BuildRequires: python3dist(numpy) >= 1.9
python-pillow.spec:BuildRequires: python3dist(numpy)
python-pytest-randomly.spec:BuildRequires: python3dist(numpy)
python-pythran.spec:BuildRequires: python3dist(numpy)
python-scipy.spec:BuildRequires: python3dist(numpy)
python-sympy.spec:BuildRequires: python3dist(numpy)
python-tabulate.spec:BuildRequires: python3dist(numpy)
python-websockify.spec:BuildRequires: python3dist(numpy)
None of those modules has any problems with latest numpy
.
Do you have any plans to update for latest numpy
?🤔
Just in case .. so in your opinion those fails are caused by numpy
?🤔
/usr/bin/python3: No module named invoke
I've alredy sorted out that and lookd like that missig dependency had no connections with those fails.
Do you have any plans to update for latest numpy?🤔
Yes I do plan to find a patch for this, hopefully in the coming days.
Just in case .. so in your opinion those fails are caused by numpy?🤔
At least most of them are caused by numpy marking dtype
as final in 1.23.1 (that was not final in 1.22.4), which some type of nptyping
inherits from, which causes mypy to complain, which causes those tests to fail.
I just released a patch that should take care of most of your errors. Can you please check again against v2.3.1?
Just tested new version
So issue has bben solved and new one popped out 😋
In this case instead sys.executable
should be used.
Correction: tests/test_wheel.py::WheelTest::test_wheel_is_built_correctly
has been failing before as well.
Just tested 2.4.0 and looks like test suite is failing now in mypy related units Here is pytest output:
Here is list of installed modules in build env
Thank you for testing (so quickly)! I will look into this.
I think I may have found the issue. My tests have been running against mypy==0.981
whereas you are using mypy==0.990
.
Can you run your tests again with mypy==0.981
just to see if this "resolves" it?
I can silence the mypy issues in a patch release to make it compatible with mypy==0.990
.
Can you run your tests again with
mypy==0.981
just to see if this "resolves" it?
I've already deleted rpm package with older mypy version :/ Sooner or later it will be necessary to move to new mypy version so .. 😋
Alright, fair enough. v2.4.1 is compatible with mypy==0.991
(and also mypy==0.990
). Can you check against this release?
Tag pattern is has been changed from v<version>
to <version>
. Mistake or from now now it will be like that?
My auomation don't care about pattern as long as it is fixed 😄
Oops... 😆 here we go: v2.4.1
OK 😄 Will back shortly 😋
Now popped out some pandas
related issues 🤔
[tkloczko@devel-g2v SPECS]$ pip show pandas
Name: pandas
Version: 1.4.2
Summary: Powerful data structures for data analysis, time series, and statistics
Home-page: https://pandas.pydata.org
Author: The Pandas Development Team
Author-email: pandas-dev@python.org
License: BSD-3-Clause
Location: /usr/lib64/python3.8/site-packages
Requires: numpy, python-dateutil, pytz
Required-by:
It seems that pandas-stubs-fork
is missing. Did you install the extra dependencies for pandas? Normally, one of the following commands would work:
pip install nptyping[pandas]
or
pip install nptyping[complete]
or
pip install nptyping[dev]
What install command did you use?
I'm installing all modules using rpm packages. As I wrote on the begginig I'm packaging all stuff as rpm packages which have python modules dependencies as rpm metadata.
In dependencies/pandas-requirements.txt I see:
pandas
pandas-stubs-fork ; python_version>="3.8"
Does it mean that this pandas-stubs-fork
is necessary only with python 3.8.x? (which I'm using now)
If yes we can ignore for now that part for now because I'm going to move all my python modules to python 3.9.x (only to develop general approach of the migration to new python major version) and than to 3.10.x and after that to 3.11.x.
In other words bringing all that to working state on top of python 3.8 is not worth your or mine time.
It means that for any Python version greater than or equal to 3.8
, pandas-stubs-fork
should be installed if hints for pandas
are to be available. That includes 3.10.x
and 3.11.x
.
Hi @ramonhagenaars,
Is there a reason you are using your own fork https://pypi.org/project/pandas-stubs-fork/
instead of the one on PyPi derived directly from https://github.com/pandas-dev/pandas-stubs
as https://pypi.org/project/pandas-stubs/
? The latter is on the same level with the GitHub repo.
I need the pandas stubs for your project nptyping
on FreeBSD ;)
A short explanation would be nice, thanks.
Hi @rhurlin ,
The reason is that the DataFrame
type of the regular pandas-stubs
does not take generics. I opened up an issue at the original project, but I didn't want to wait with the DataFrame
support. Hopefully, eventually, I can drop this fork and use the original.
Hi @ramonhagenaars, hanks for the explanation.
Since I want to port your project nptyping
to FreeBSD, and for that I need to port the original repo pandas-stubs
as well if possible, I will probably wait a bit with that.
Just tested 2.5.0 and some units still are failing
gentle ping .. ay update? 🤔
@kloczek, not sure if you need it directly but in Gentoo we only needed it for tests in sphinx-autodoc-typehints. I've just removed the deps and marked nptyping for removal.
@kloczek, not sure if you need it directly but in Gentoo we only needed it for tests in sphinx-autodoc-typehints. I've just removed the deps and marked nptyping for removal.
Just checked and .. it is yet another module
[tkloczko@pers-jacek SPECS]$ grep "BuildRequires:.*python3dist(nptyping)" *
python-sphinx-autodoc-typehints.spec:BuildRequires: python3dist(nptyping)
python-typish.spec:BuildRequires: python3dist(nptyping)}
I'm packaging your module as an rpm package so I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.
python3 -sBm build -w --no-isolation
build
with--no-isolation
I'm using during all processes only locally installed modulesHere is pytest output:
Here is list of installed modules in build env