search

ramonhagenaars / nptyping

💡 Type hints for Numpy and Pandas
MIT License
589 stars 30 forks source link

PYPI tarball does not include dependencies dir #98

Closed MatthewZMD closed 1 year ago

MatthewZMD commented 1 year ago

Hey folks, is the PYPI release maintained by you too? Apparently it does not contain dependencies/build-requirements.txt, using the PYPI release will fail setup.py that explicitly required dependencies/build-requirements.txt

FileNotFoundError: [Errno 2] No such file or directory: '.../nptyping-2.3.1/dependencies/build-requirements.txt'
ramonhagenaars commented 1 year ago

Hi @MatthewZMD ! Thanks for pointing this out, this doesn't seem right.

rhurlin commented 1 year ago

Any chance to get a new PyPi version with the dependencies directory in the near future?

BTW, it would be nice if this would happen for the tests directory as well, since systems like FreeBSD use the tests in their ports and packages. I'm preparing a port for nptyping and would like to integrate the tests ;)

Thank you for your understanding! Rainer

ramonhagenaars commented 1 year ago

Hi folks.

Starting with release 2.5.0 (in the making), the distribution will include the requirement files, tests, etc.

rhurlin commented 1 year ago

Hi @ramonhagenaars, Many thanks! Really appreciated. I will use it in my next packaging on FreeBSD, after 2.5.0 is released.

ramonhagenaars commented 1 year ago

With v2.5.0 this issue should be resolved. Please let me know if you encounter any problems still.