search

ramosbugs / openidconnect-rs

OpenID Connect Library for Rust
MIT License
427 stars 103 forks source link

Support standard OIDC birthdate claim #119

Closed alex-swift closed 1 year ago

alex-swift commented 1 year ago

OpenID Connect Core defines the list of the standard claims https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims. One of these claims is birthdate.

StandardClaims structure supports birthday, but does not support birthdate: @see https://github.com/ramosbugs/openidconnect-rs/blob/1bc4a2f6c741f1c94716c5f4d897b0f3eaa06fbe/src/claims.rs#L107

Could you please add support for birthdate claim or rename birthday by birthdate?

ramosbugs commented 1 year ago

ah shoot this looks like a typo. nice catch!

to avoid introducing a breaking change in case anyone depends on birthday, I think we'll need to add birthdate (of existing type EndUserBirthday) rather than rename birthday. I'm not sure when I'll have time to do this, but I would be happy to merge a PR that does this (with test coverage that adds the field to existing tests).

alex-swift commented 1 year ago

@ramosbugs, please review https://github.com/ramosbugs/openidconnect-rs/pull/120

alex-swift commented 1 year ago

Thank you for quick response.

ramosbugs commented 1 year ago

This is now fixed in 3.3.0