ramosbugs / openidconnect-rs

OpenID Connect Library for Rust
MIT License
372 stars 98 forks source link

add EdDSA alg support #130

Closed xshadowlegendx closed 9 months ago

xshadowlegendx commented 9 months ago

this pr contains

discussion: issue

lastly thanks everyone for all your awesome work on this library and happy to have any feedback about this pr

codecov[bot] commented 9 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (6747400) 51.56% compared to head (33c5efa) 51.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #130 +/- ## ========================================== + Coverage 51.56% 51.79% +0.22% ========================================== Files 16 16 Lines 2075 2145 +70 ========================================== + Hits 1070 1111 +41 - Misses 1005 1034 +29 ``` | [Files](https://app.codecov.io/gh/ramosbugs/openidconnect-rs/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Ramos) | Coverage Δ | | |---|---|---| | [src/jwt.rs](https://app.codecov.io/gh/ramosbugs/openidconnect-rs/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Ramos#diff-c3JjL2p3dC5ycw==) | `74.57% <ø> (ø)` | | | [src/core/mod.rs](https://app.codecov.io/gh/ramosbugs/openidconnect-rs/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Ramos#diff-c3JjL2NvcmUvbW9kLnJz) | `52.21% <25.00%> (-0.55%)` | :arrow_down: | | [src/core/crypto.rs](https://app.codecov.io/gh/ramosbugs/openidconnect-rs/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Ramos#diff-c3JjL2NvcmUvY3J5cHRvLnJz) | `73.91% <70.00%> (-1.60%)` | :arrow_down: | | [src/core/jwk.rs](https://app.codecov.io/gh/ramosbugs/openidconnect-rs/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Ramos#diff-c3JjL2NvcmUvandrLnJz) | `77.88% <76.66%> (-0.20%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/ramosbugs/openidconnect-rs/pull/130/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=David+Ramos)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ramosbugs commented 9 months ago

also, be sure to update the MSRV lock file Cargo-1.65.lock to address the failing 1.65.0 CI build:

cp Cargo-1.65.lock Cargo.lock
cargo check
cp Cargo.lock Cargo-1.65.lock
ramosbugs commented 9 months ago

This is now released in 3.4.0!