search

ramosbugs / openidconnect-rs

OpenID Connect Library for Rust
MIT License
427 stars 103 forks source link

Replace constant time from ring with subtle #89

Closed ctron closed 2 years ago

ctron commented 2 years ago

This PR tries to start working towards #58 … but chopping it down into smaller pieces.

codecov[bot] commented 2 years ago

Codecov Report

Merging #89 (5956f37) into main (32603ad) will increase coverage by 0.07%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   72.11%   72.18%   +0.07%     
==========================================
  Files          16       16              
  Lines        3794     3793       -1     
==========================================
+ Hits         2736     2738       +2     
+ Misses       1058     1055       -3
Impacted Files Coverage Δ
src/types.rs 70.74% <100.00%> (+0.91%) :arrow_up:
src/verification.rs 86.22% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ramosbugs commented 2 years ago

Codecov Report

Merging #89 (d1ce1f3) into main (2f79ac2) will decrease coverage by 22.74%. The diff coverage is 100.00%.

...that's definitely not right, Codecov.

ramosbugs commented 2 years ago

Hopefully #90 will help with the coverage weirdness

ctron commented 2 years ago

I updated the PR.

ctron commented 2 years ago

Is there something I need to do?

ramosbugs commented 2 years ago

Looks like CI is failing due to a clippy lint. Once it passes I'll merge the PR.

ctron commented 2 years ago

Sorry, fixed that. And rebased too.

ramosbugs commented 2 years ago

thanks!