search

ramosian-glider / memory-sanitizer

Automatically exported from code.google.com/p/memory-sanitizer
0 stars 0 forks source link

False positive uninit reported for varaible created by vp8_variance16x16_wmt #45

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
msandr reports uninit error on content_browsertests 
WebRtcAecDumpBrowserTest.CallWithAecDump

[369/470] WebUIResourceBrowserTest.MediaInternals_Manager (6599 ms)
Note: Google Test filter = WebRtcAecDumpBrowserTest.CallWithAecDump
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from WebRtcAecDumpBrowserTest, where TypeParam =
[ RUN      ] WebRtcAecDumpBrowserTest.CallWithAecDump
[22100:22116:0130/123557:1826453235601:WARNING:proxy_service.cc(901)] PAC 
support disabled because there is no system implementation
[22124:22124:0130/123559:1826454839247:ERROR:renderer_main.cc(223)] Running 
without renderer sandbox
[22100:22100:0130/123600:1826456386156:INFO:CONSOLE(40)] "Looking at video in 
element remote-view-1", source: 
http://127.0.0.1:43889/media/webrtc_test_utilities.js (40)
[22100:22100:0130/123601:1826456450902:INFO:CONSOLE(40)] "Looking at video in 
element remote-view-2", source: 
http://127.0.0.1:43889/media/webrtc_test_utilities.js (40)
[22100:22100:0130/123601:1826456549532:INFO:CONSOLE(644)] "Negotiating 
call...", source: http://127.0.0.1:43889/media/peerconnection-call.html (644)
[22124:22132:0130/123601:1826456566139:ERROR:webrtc_video_sink_adapter.cc(45)] 
Not implemented reached in virtual void 
content::WebRtcVideoSinkAdapter::SetSize(int, int)
[22100:22100:0130/123603:1826459264608:INFO:CONSOLE(667)] "Receiving offer...", 
source: http://127.0.0.1:43889/media/peerconnection-call.html (667)
[22100:22100:0130/123604:1826459510606:INFO:CONSOLE(768)] "Receiving remote 
stream...", source: http://127.0.0.1:43889/media/peerconnection-call.html (768)
[22100:22100:0130/123604:1826459614830:INFO:CONSOLE(741)] "Receiving 
answer...", source: http://127.0.0.1:43889/media/peerconnection-call.html (741)
[22100:22100:0130/123604:1826459925922:INFO:CONSOLE(768)] "Receiving remote 
stream...", source: http://127.0.0.1:43889/media/peerconnection-call.html (768)
WARNING: no real random source present!
==22124== WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x7f6d01e27db8 in vp8_pick_intra_mode /usr/local/google/home/zhaoqin/Workspace/Chrome/chromium.git/src/out/Release/../../third_party/libvpx/source/libvpx/vp8/encoder/pickinter.c:1277
    #1 0x7f6d01e71f80 in vp8cx_encode_intra_macroblock /usr/local/google/home/zhaoqin/Workspace/Chrome/chromium.git/src/out/Release/../../third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:1172
    #2 0x7f6d01e70095 in encode_mb_row /usr/local/google/home/zhaoqin/Workspace/Chrome/chromium.git/src/out/Release/../../third_party/libvpx/source/libvpx/vp8/encoder/encodeframe.c:502
    ...

  Uninitialized value was created by an allocation of 'sum0' in the stack frame of function 'vp8_variance16x16_wmt'
    #0 0x7f6cf78904c0 in vp8_variance16x16_wmt /usr/local/google/home/zhaoqin/Workspace/Chrome/chromium.git/src/out/Release/../../third_party/libvpx/source/libvpx/vp8/common/x86/variance_sse2.c:180

It seems a false positive due to msan cannot handle inline asm code:
unsigned int vp8_variance16x16_wmt(...)
{
    unsigned int sse0;
    int sum0;
    vp8_get16x16var_sse2(src_ptr, source_stride, ref_ptr, recon_stride, &sse0, &sum0) ;
    ...
}

vp8_get16x16var_sse2 is implemented as a asm routine in 
third_party/libvpx/source/libvpx/vp8/common/x86/variance_impl_sse2.asm, in 
which sum is initialized.

Original issue reported on code.google.com by zhao...@chromium.org on 31 Jan 2014 at 4:02

GoogleCodeExporter commented 9 years ago

Original comment by konstant...@gmail.com on 1 Feb 2014 at 4:39

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
filed as crbug.com/340754

Original comment by zhao...@google.com on 6 Feb 2014 at 4:56

GoogleCodeExporter commented 9 years ago

Original comment by earth...@google.com on 6 Feb 2014 at 5:41

GoogleCodeExporter commented 9 years ago 
Adding Project:MemorySanitizer as part of GitHub migration.

Original comment by gli...@google.com on 30 Jul 2015 at 9:22