search

ramosian-glider / sanitizers

0 stars 0 forks source link

[Refactoring] Move large method implementations outside class definitions #150

Closed ramosian-glider closed 9 years ago

ramosian-glider commented 9 years ago

Originally reported on Google Code with ID 149

According to Google C++ Style Guide:

>Do not put large method definitions inline in the class definition. 
>Usually, only trivial or performance-critical, and very short, methods 
>may be defined inline. See Inline Functions for more details.

(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Declaration_Order#Declaration_Order)

I think this makes sense, as large methods bloat the class definitions and make them
impossible to read.

Reported by ramosian.glider on 2013-02-05 11:03:33

ramosian-glider commented 9 years ago 
I see no reason for a "refactoring" bug, as well for the refactoring itself. 
For the particular "large methods" in the sanitizer_allocator.h: they
are templates, so making them outline will bloat the code even worse.

Reported by konstantin.s.serebryany on 2013-02-15 13:05:42

ramosian-glider commented 9 years ago 
Adding Project:AddressSanitizer as part of GitHub migration.

Reported by ramosian.glider on 2015-07-30 09:13:40