ramou / ChessMod

Adding Pippin Barr's Chesses to minecraft.
MIT License
3 stars 3 forks source link

Create something to keep track of `enderpearl` stack #169

Closed riri404 closed 5 months ago

riri404 commented 5 months ago

I need to find a way to keep track of the enderpearl stack so I don't run into board linking issue. Basically, board1 and board2 can link properly, but if I place board3 and board4, they will link to board1, assumption that this is the cause of this problem is that board3 and board4 are linking to the nbt of board1. I drew something to help me visualize the problem.

WhatsApp Image 2024-04-29 at 11 58 13_bca4ff8d

riri404 commented 5 months ago

potential solution: Adding a custom NBT tag within the chessboard block entity itself, also gotta clear the stored data so we can create another link. Will this cause issues with the first linking? gonna find out this afternoon :))

ramou commented 5 months ago

Nope, it doesn't belong with the chessboard for sure. We're better off making our own unstackable item that turns an unstacked ender pearl into a linking pearl.

On Mon, Apr 29, 2024 at 1:15 PM Rama @.***> wrote:

potential solution: Adding a custom NBT tag within the chessboard block entity itself, also gotta clear the stored data so we can create another link. Will this cause issues with the first linking? gonna find out this afternoon :))

— Reply to this email directly, view it on GitHub https://github.com/ramou/ChessMod/issues/169#issuecomment-2083145533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN2OQBN7JHGVXV55Q6CLB3Y7ZW3RAVCNFSM6AAAAABG6TZYW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTGE2DKNJTGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Dr. Stuart Thiel, P. Eng.

riri404 commented 5 months ago

my bad I meant QuantumChessBoardEntity. creating an item might make it more chaotic, no? I think we add a chessboardID to the nbt of the quantum chessboard so we can check the IDs before linking

riri404 commented 5 months ago

I'm almost done I'll finish testing and push to a new branch so you can review

ramou commented 5 months ago

If you wanted to make a guid for the linkage so that it can't be linked to something else, the ender pearl would need to hold that anyway, and it doesn't change the issue with the stack, which has to contain what's going on. If the problem you're trying to solve is that the whole stack of ender pearls is taking on state and linking isn't properly clearing that state, there are several solutions to consider to address that specific problem, but none of them likely benefit from adding meta-data to a board as the long-term reason to do that would be to prevent weird linking, which is easily enough done with a check to see who got in first and the general (if perhaps more sophisticated) validation of the link on usage.

On Mon, Apr 29, 2024 at 1:46 PM Rama @.***> wrote:

I'm almost done I'll finish testing and push to a new branch so you can review

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

-- Dr. Stuart Thiel, P. Eng.

riri404 commented 5 months ago

that makes sense, I did enjoy playing with the NBTs tho :) I will push to anew branch just to show you what I did exactly

ramou commented 5 months ago

Sounds good... don't worry, you'll still get to play with NBTs with the items. Same mechanism.

On Mon, Apr 29, 2024 at 2:04 PM Rama @.***> wrote:

that makes sense, I did enjoy playing with the NBTs tho :) I will push to anew branch just to show you what I did exactly

— Reply to this email directly, view it on GitHub https://github.com/ramou/ChessMod/issues/169#issuecomment-2083232178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN2OQCMROTKN7L2MH3P743Y7Z4SHAVCNFSM6AAAAABG6TZYW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTGIZTEMJXHA . You are receiving this because you commented.Message ID: @.***>

-- Dr. Stuart Thiel, P. Eng.