search

ramp4-pcar4 / config-editor

A config editor for RAMP4.
1 stars 1 forks source link

Language CRUD #5

Open james-rae opened 1 year ago

james-rae commented 1 year ago

One of the limitations of the app at the moment is you cannot add or delete languages. You either have the ones you passed in the initial config, or English and French by default. Consider adding a way for the user to add/remove configs for languages in the middle of the session.

mohsin-r commented 5 months ago

Looking at this one again, I think it warrants a discussion before deciding to implement. This is because allowing users to CRUD languages willy nilly has significant implications for storylines products where the languages are somewhat set to English and French, at least in the RESPECT editor.

james-rae commented 4 months ago

@mohsin-r agreed. Given that a lot of our language keys are bundled at build time, supporting a 3rd language would also require an update to all lang.csvs in the codebase and a rebuild.

Adding this to config editor would probably cause more issues rather than providing a fancy feature.