search

ramp4-pcar4 / ramp4-pcar4

RAMP 4 - The Reusable Accessible Mapping Platform, fourth major version
https://ramp4-pcar4.github.io/ramp4-pcar4/main/docs/
Other
17 stars 22 forks source link

Add Storyline PR demo #2177

Open szczz opened 6 months ago

szczz commented 6 months ago

Description

Discussed in the April 9th R4MP meeting

We would like to add a Storyline demo build to our PRs to help us catch issues that appear in Storylines products. There has been a few recent issues that weren't found until the Storylines team upgraded their R4MP version. This should also reduce some of the burden on the QA team.

We decided to use the "00000000-0000-0000-0000-000000000000" Storyline that is generated with a story-ramp npm build. @dan-bowerman mentioned some changes might be needed to this down the line, so we can either list those here or create a new issue in the story-ramp repo.

james-rae commented 6 months ago

Also mentioned, we would want our github-actions auto bot post of "Your demo site is ready" to add a fourth link to the storylines sample for that PR

james-rae commented 5 months ago

Curious how this proposal will work in concert with https://github.com/ramp4-pcar4/story-ramp/issues/431

If storylines has npm/ramp as a build dependency, then npm/storylines package will have the last released version of ramp inside it. Yet we want to have a build that uses the cut of RAMP that was just PR'd in the RAMP repo.

Out of my wheelhouse, but I feel you'd have to have the Github Action that builds the PR demo grab the storylines source, magically flick the RAMP out of it's package.json, build it without exploding due to that flicking, then inject the RAMP built for the PR demo. Hopefully there is an easier way?