ramp4-pcar4 / story-ramp

Storytelling with interactive maps using RAMP

MIT License

4 stars 13 forks source link

Migrate Storylines to RAMP4 #377

Closed mohsin-r closed 9 months ago

mohsin-r commented 1 year ago

~~No Pulling.~~ Ready for full review now. Worked on jointly with @roryhofland.

This PR is essentially an enormous rebase of our previous RAMP4 demo in January, with a couple of small enhancements thrown in. Full list of changes:

Storylines now uses RAMP4 for map panels
gutted any RAMP2 styling that was causing conflicts
config files have been converted to RAMP4
the Timeslider fixture was ported to RAMP4

There are still a few quirks, some of which may require changes in RAMP4.

This change is

github-actions[bot] commented 1 year ago

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/ramp4/#/en/00000000-0000-0000-0000-000000000000

james-rae commented 1 year ago

Map appears really fast. I guess having the story "title / landing" first gives it a few seconds to pull down the library, but from a consumer perspective I would not complain about a lagging load time.

mohsin-r commented 10 months ago

Rebased.

spencerwahl commented 9 months ago

It seems like at least some of the issues are causes by a github pages 404 styling block? Hard to tell for sure.

spencerwahl commented 9 months ago

392 continued this PR and was merged, closing this one