rework panel ordering to allow multimedia on the left panel - Githubissues

ramp4-pcar4 / story-ramp

Storytelling with interactive maps using RAMP

MIT License

4 stars 14 forks source link

rework panel ordering to allow multimedia on the left panel #416

Closed RyanCoulsonCA closed 6 months ago

RyanCoulsonCA commented 6 months ago

Related Item(s)

https://github.com/ramp4-pcar4/storylines-editor/issues/252, https://github.com/ramp4-pcar4/storylines-editor/pull/274

Changes

Previously, we would always put the text panel on the left and sticky the right panel if it was multimedia. Logic has now been modified to respect config ordering.
On mobile, the multimedia panel will be prioritized first over a text panel. For all of the ordering rules see the comment in the PR.

Testing

Steps:

Open the demo page and ensure that the Default RAMP4 Sample slide is swapped correctly. The map should be on the left and the text should be on the right. In mobile view, the map should be stuck to the top.
The Pollution in your neighbourhood slide has two text panels next to each other. Ensure that these are still displaying in the correct order.
Play around with the app in mobile mode and ensure things are working as expected.

This change is

github-actions[bot] commented 6 months ago

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-252/#/en/00000000-0000-0000-0000-000000000000