search

ramp4-pcar4 / story-ramp

Storytelling with interactive maps using RAMP
MIT License
4 stars 14 forks source link

Exclude ramp-pcar from being bundled in NPM plugin build #457

Closed yileifeng closed 5 days ago

yileifeng commented 2 weeks ago

Related Item(s)

https://github.com/ramp4-pcar4/storylines-editor/issues/380

Changes

Testing

None, needs testing after upgrading version in editor

This change is Reviewable

github-actions[bot] commented 2 weeks ago

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/exclude-ramp-build/#/en/00000000-0000-0000-0000-000000000000

james-rae commented 2 weeks ago

Did these concerns get proven to be not a problem? https://github.com/ramp4-pcar4/storylines-editor/issues/380#issuecomment-2315742341

Cuz if not this is likely a breaking change for anything consuming ramp-storylines_demo-scenarios-pcar from npm unless they pinned.

Is this PR to experiment with what happens? Or has trigger been pulled on this new build strategy?