ramp4-pcar4 / storylines-editor

An editor for RAMP Storylines
5 stars 13 forks source link

Fix accessibility errors #379

Closed IshavSohal closed 1 month ago

IshavSohal commented 2 months ago

Related Item(s)

362

Changes

Notes

Testing

Steps:

  1. Open storylines to the 'choose language page'. Open the WAVE extension and observe that there are no (non-highcharts) errors
  2. Click English to open the 'create/edit product option' page. Open the WAVE extension and observe that there are no (non-highcharts) errors
  3. Click on the 'Create New Storylines Product' button to open the 'new product page'. Open the WAVE extension and observe that there are no (non-highcharts) errors
  4. Go back to the 'create/edit product option page'
  5. Click on the 'Edit Existing Storylines Product Button' to open the 'edit existing product' page. Enter an uuid of:
    00000000-0000-0000-0000-000000000000
  6. Open the WAVE extension and observe that there are no (non-highcharts) errors
  7. Click the 'Load' button. Open the WAVE extension and observe that there are no (non-highcharts) errors
  8. Click the 'Next' button to open the main editor page. Open the WAVE extension and observe that there are no (non-highcharts) errors

This change is Reviewable

github-actions[bot] commented 2 months ago

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/issue-362-fix

IshavSohal commented 2 months ago

Most of the editor specific WAVE errors got cleared so nice work, will make a new issue for the RAMP config accessibility errors. Just one more error popping up on the video editor:

  • missing form label on the paste URL input for video editor

Reviewable status: 0 of 15 files reviewed, 2 unresolved discussions

Sorry, forgot to respond to this earlier. I'm not getting this error on my end. Is it still occurring for you?

IshavSohal commented 2 months ago

Should be fixed now.