search

ramp4-pcar4 / storylines-editor

An editor for RAMP Storylines
5 stars 13 forks source link

Dashboard Redesign #389

Open IshavSohal opened 2 months ago

IshavSohal commented 2 months ago

Related Item(s)

373

Changes

Testing

Steps:

  1. Open the app and select any language
  2. Observe the dashboard

This change is Reviewable

github-actions[bot] commented 2 months ago

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/dashboard-redesign

IshavSohal commented 1 month ago

src/components/home.vue line 6 at r2 (raw file):

Previously, yileifeng (Yi Lei Feng) wrote…
Hmm this strategy will not work since the template gets rendered when we are on the index-ca-en.html or index-ca-fr.html page. For example, following the https://ramp4-pcar4.github.io/storylines-editor/dashboard-redesign/index-ca-en.html#/en/editor demo link will load the Canada template and see the following results with two lang toggles: ![image.png](https://files.reviewableusercontent.io/images/reviewable/31557789/XTZm2IrynGAJr9AjuxRmNXfd/image.png) Not sure if there is already an existing check in the codebase for this, but a potential solution(?) for this might be to search for "index-ca-en.html" or "index-ca-fr.html" inside the Vue Router object's URL. Another approach would be to set a flag determining if we are using Canada.ca template inside the Router's meta fields and just have the conditional check on that.

Donethanks, I made it so that the language toggle doesn't render when the current source page is "index-ca-en.html" or "index-ca-fr.html"

IshavSohal commented 1 month ago

Donethanks

szczz commented 6 days ago

Sorry for the delay, service desk and licensing delays held things up. lastModified date is being returned from the API now. Please proceed with updating the frontend to display the Last Modified date (Most records are set to the time of DB migration, but this will be updated as changes are made to storylines)

IshavSohal commented 1 day ago

Donethanks