search

ramp4-pcar4 / storylines-editor

An editor for RAMP Storylines
5 stars 13 forks source link

Selecting some map slides freezes the app #411

Open gordlin opened 1 month ago

gordlin commented 1 month ago

Description

Clicking on SOME slides with map panels causes all other items on the table of contents to be unselectable.

An error pops up in the console, indicating this is likely an issue with these panels not having a RAMP instance somehow: TypeError: this.rampEditorApi.getConfig is not a function The RAMP config editor also doesn't appear.

Environment

Steps to reproduce

  1. Go to https://ramp4-pcar4.github.io/storylines-editor/main/#/en/editor-main/00000000-0000-0000-0000-000000000000
  2. Click slide 1. It works.
  3. Click slide 2, the one with the default RAMP sample. Now try to select any other slide. You can't (unless you change to the right panel, then select). Selecting other slides doesn't work anymore.
  4. This doesn't seem to occur for newly-created map panels.

Expected behavior

Should be able to select another slide. RAMP config editor should appear when the slide is selected.

Actual behavior

Freezing. No config editor.

IshavSohal commented 6 days ago

I think this issue occurs when the config src of a map panel is incorrect (within the product's json). Note that, within the ramp-config folder of the product, some configs are in the en or fr folders, while others (i.e. newly added ones) sit directly in the ramp-config folder. If the config src is correct I don't believe this issue should occur, but correct me if I'm wrong.