search

rampasek / GraphGPS

Recipe for a General, Powerful, Scalable Graph Transformer
MIT License
643 stars 114 forks source link

compatibility issues fixed #2

Closed jakubgajski closed 2 years ago

jakubgajski commented 2 years ago
  1. Seems like currently supported versions of pytoch geometric doesn't have optimizer module, but optim instead.
  2. Create optimizer is searching for optimizer_config attribute.
rampasek commented 2 years ago

Hello Jakub,

Thank you for your interest in GraphGPS.

What version of PyG are you using? The codebase as is currently requires PyG 2.0.2 (see the README) -- there should be no issues when using that version.

I plan to upgrade the compatibility to PyG 2.0.4 in several days.

Best, Ladislav

jakubgajski commented 2 years ago

Hi Ladislav

Thanks for this great repo and published paper!

I'm using PyG 2.0.4, but initially I have tried to setup an environment with requirements from README without success.

I have checked once again why I needed to change it. Now I think that it's caused by my CUDA version, which requires PyTorch >=1.11, and thus also newer PyG (I suppose).

Anyway, feel free to reject this MR, or even to use fixes for your next release. Regards, Jakub

rampasek commented 2 years ago

Hi,

Thank you, I'll close this PR and upgrade the codebase to PyG 2.0.4 compatibility later. Seems there will be more issues to be solved with the new optimizer configuration in PyG 2.0.4, as here in GraphGPS I have 2 custom optimizers that will need to be refactored as well.

Thanks again, Ladislav