rampasek / GraphGPS

Recipe for a General, Powerful, Scalable Graph Transformer
MIT License
643 stars 114 forks source link

[FIX] Stable sorting in graphormer encoder #46

Open luis-mueller opened 8 months ago

luis-mueller commented 8 months ago

Indeed, the stable sorting was missing on add_graph_token in the graphormer encoder. I ran Graphormer on ZINC for 1000 epochs with and without the stable sorting but couldn't find any difference in performance. Anyway, the stable sorting is definitely needed to preserve the original order of node embeddings.

Closes #40.