rampatra / jbot

Make Slack and Facebook Bots in Java.
GNU General Public License v3.0
1.2k stars 352 forks source link

Dependency refresh #203

Closed jbeemster closed 1 year ago

jbeemster commented 1 year ago

This PR upgrades Maven and SpringBoot to more recent versions without a ton of CVEs present while trying to keep code changes to an absolute minimum.

There was one revert that needed to happen to get tests to pass again which was related to the Facebook bot - running the tests without that reversion caused this stacktrace:

[ERROR]   FbBotTest.When_QuickReplyInCallback_Then_InvokeOnReceiveQuickReply:61
Expected: a string containing "Quick reply button clicked with payload 'yes'"
     but: was "17:21:43.947 [main] DEBUG me.ramswaroop.jbot.core.facebook.Bot - Callback from fb:
17:21:43.951 [main] ERROR me.ramswaroop.jbot.core.facebook.models.Event - Error serializing object:
com.fasterxml.jackson.databind.JsonMappingException: (was java.lang.NullPointerException) (through reference chain: me.ramswaroop.jbot.core.facebook.models.Event["patternFromEventType"])

Moving the code back to where it was prior to the Refactoring commit makes all tests pass again - I didn't dig very deeply into why this was causing issues with Jackson but this seemed like the fast option to get things working again!