rampatra / photography

A free online portfolio website to showcase your photos.
http://photography.rampatra.com
GNU General Public License v3.0
953 stars 987 forks source link

Initial loading flicker on first visit #114

Open mobeigi opened 4 weeks ago

mobeigi commented 4 weeks ago

There is a problem with the initial load for this project.

It will flicker on a fresh un-cached load:

https://github.com/user-attachments/assets/2353e3ad-cba3-40cf-98f5-4b87b5f03964

This is more obvious if you intentionally slow down your network data to 3G using Chrome Dev tools etc.

The issue is a result of main.js being too slow to load and set the loading state.

On my fork at https://github.com/mobeigi/photography

I've fixed this and also made a handful of other improvements including:

I'd be happy to put up a PR for all of this, but my last pr was not reviewed so I don't know if its worth the time.

If it will be reviewed let me know and I can put up a PR @rampatra

rampatra commented 4 weeks ago

All the points you mentioned sounds interesting, would be great if you can raise a PR 🙏. And, your earlier PR is merged too.

mobeigi commented 4 weeks ago

Good to hear, I'll make a PR shortly with the improvements!