Open ghost opened 4 years ago
I've run into this as well, and I agree with @Sydpy's conclusion.
I wonder if the additional complexity is even worth it. I feel like that Spotify API feature is mainly useful for dynamically typed languages, where specifying the fields you're working with is a quick low-effort change to reduce load. But in Rust, you'd have to use a different type, and then .unwrap()
all the fields you're working with - a significant amount of friction. To keep rspotify's API simple, maybe this feature shouldn't be implemented?
I think there's enough value in this feature for it to not be abandoned. At the time of my previous comment, I had hacked together a proof of concept to test if it actually made a difference for my workflow (fetching the IDs of all tracks in a playlist), and the speed difference was significant.
a proof of concept to test if it actually made a difference for my workflow (fetching the IDs of all tracks in a playlist), and the speed difference was significant.
That is interesting. Can you share the benchmarking code?
That is interesting. Can you share the benchmarking code?
Unfortunately, it was just a quick hack job to informally test it and was not saved. If I recall correctly, it was pretty much copy-pasting the relevant structs and functions required to make it work, tweaking the struct to only save the ID (I don't recall if I made the other fields Optional or removed them entirely), and passing the fields
parameter to only fetch the ID.
I've just ran into this issue. Forgive me if I'm missing something here, but why is the fields
parameter provided if using it doesn't work?
Some Spotify endpoints, especially the ones returning a paging object, allow to specify the fields that we want to fetch.
For example,
Get a Playlist's Items
has afields
query parameter that allow selection of fields, but we can't use it since it would raise an error when trying to deserialize the fields that are not specify :This behaviour makes the
fields
parameter useless and forces to fetch data even if we don't need it. Solutions to that would be :#[serde(default)]
on existing model object fieldsOption
on existing model object fieldsPartialTrack
, that implement either1.
or2.
and make endpoints that use afields
query parameter return such aPartial
object instead of aFull
orSimplified
one.I think
3.
would be the most reasonable solution, moreover it might be possible to implement it using a macro.