Make `available_markets` optional

ramsayleung / rspotify

Spotify Web API SDK implemented on Rust

MIT License

639 stars 123 forks source link

Make `available_markets` optional #286

Closed hrkfdn closed 2 years ago

hrkfdn commented 2 years ago

Description

Fixes https://github.com/ramsayleung/rspotify/issues/285

Type of change

Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Test suite was extended

marioortizmanero commented 2 years ago

Could you please add these changes to the changelog? You might have to make a new entry, I forgot about that. We can release it for 0.11.3.

hrkfdn commented 2 years ago

@marioortizmanero Like this?

marioortizmanero commented 2 years ago

Perfect, thanks a lot for the contribution! <3

hrkfdn commented 2 years ago

@marioortizmanero Sure :)! Do you have a rough estimate on when you'll release 0.11.3?

marioortizmanero commented 2 years ago

I'd like to close #281. I'm still not fully sure about how to approach for rspotify-model, but we need it ASAP because otherwise most of the links in the docs are broken. Also merging all the pending PRs, but that should be pretty easy.