#385 Multiple `AlbumType` for `BaseClient::artist_albums_manual`

ekuinox commented 1 year ago

Description

fixes: #385

This change will allow BaseClient::artist_albums_manual to be given more than one AlbumType. And It rename album_type of query parameter name to include_groups.

Motivation and Context

I want to get artist's albums by some AlbumType.

Dependencies

No changes.

Type of change

Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Please also list any relevant details for your test configuration

[x] Test A: test_artists_albums
- My change doesnot break previous BaseClient::artist_albums_manual calls.
[x] Test B: test_artists_albums_with_multiple_album_types
- AddBaseClient::artist_albums_manual call by AlbumType array.

Is this change properly documented?

Please make sure you've properly documented the changes you're making.

Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements).

[x] Added to changelog.

ramsayleung commented 1 year ago

Thanks for your contribution :)

The CI checks failed, would you like to fix it in this PR, otherwise I could create a new PR to fix this problem.

PS:

As for the CI problem, @aplanas has fixed it in https://github.com/ramsayleung/rspotify/pull/388, so we don't need additional modification. You could just rebase the latest commit in the master branch.

ekuinox commented 1 year ago

thank you reviewing!

I will respond to the point pointed out within this PR.

ramsayleung / rspotify