ramsayleung / rspotify

Spotify Web API SDK implemented on Rust
MIT License
632 stars 121 forks source link

Route `/v1/shows/{id}` requires market query parameter but `get_a_show` market parameter is `Option` #442

Closed oSumAtrIX closed 11 months ago

oSumAtrIX commented 11 months ago

Spotify documents that the route /v1/shows/{id} requires a market query parameter but get_a_show market parameter is Option. If None is supplied, the request will fail with status code 404 as documented.

ramsayleung commented 11 months ago

The document doesn't mark the market parameter as required.

If None is supplied, the request will fail with status code 404 as documented

From the document, it's by design:

Note: If neither market or user country are provided, the content is considered unavailable for the client. Users can view the country that is associated with their account in the account settings.

I could remove the option field, and mark the market as required

oSumAtrIX commented 11 months ago

I understand where you are coming from. The documentation indeed treats it as optional, thus the implementation reflects the correct design.