Closed cyqsimon closed 7 months ago
Thanks for being so expedient. Maybe a little too expedient because I didn't add a changelog yet 😅. You may wish to do that manually FYI.
Can you please consider making a patch release for this? This will allow me to fix the problem in ncspot. Much thanks.
I am on vacation right now, I will release a new version when I am back :)
On Sun, Feb 4, 2024 at 4:09 PM cyqsimon @.***> wrote:
Can you please consider making a patch release for this? This will allow me to fix the problem in ncspot. Much thanks.
— Reply to this email directly, view it on GitHub https://github.com/ramsayleung/rspotify/pull/455#issuecomment-1925623290, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGCSM7FWEVXYYCYWCAKX3YR465LAVCNFSM6AAAAABCO6PIYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGYZDGMRZGA . You are receiving this because you modified the open/close state.Message ID: @.***>
Sorry to ping you again 😅; just a reminder in case you forgot about this. Thanks again.
Thanks for the follow-up, I was working on revert the patch for Spotify Bug before, the v0.13.0 is released: https://github.com/ramsayleung/rspotify/pull/462
Description
Enable proxy detection when using
ureq
as HTTP client, making it consistent with usingreqwest
.Motivation and Context
I found a proxy leak in hrkfdn/ncspot#1384 and traced it back to this crate.
Dependencies
None.
Type of change
Should this count as a bug fix or a new feature? I'm not sure.
How has this been tested?
This is a very minor change that simply calls a function of a dependency. I think it's okay to forgo tests.
Is this change properly documented?
lib.rs
documentation updated