ramsayleung / rspotify

Spotify Web API SDK implemented on Rust
MIT License
632 stars 121 forks source link

[Fix] Fix the filter of GitHub Action on event #463

Closed ramsayleung closed 6 months ago

ramsayleung commented 6 months ago

Description

Fix the filter of GitHub Action on event

Motivation and Context

The on section specifies the events that trigger workflow, what I expect is the workflow only get triggered when new tag name v* is created(e.g. new version is published).

However, the current configuration will trigger the workflow not only when a new tag is created but also when any other type of creation event occurs(such as creating a new branch)

Fixing it by enclosing the tag pattern 'v*' in single quotes, it should explicitly specfy that the workflow should trigger only when a new tg matching that pattern is created.

Dependencies

None

Type of change

Please delete options that are not relevant.

How has this been tested?

This PR shoudn't trigger the Publish Create workflow

Is this change properly documented?

It's unnecessary.