Closed jirutka closed 5 months ago
native-tls
enables an adapter so you can pass anative_tls::TlsConnector
instance toAgentBuilder::tls_connector
. Due to the risk of diamond dependencies accidentally switching on an unwanted TLS implementation,native-tls
is never picked up as a default or used by the crate level convenience calls (ureq::get
etc) – it must be configured on the agent. -- https://github.com/algesten/ureq#features
If I understand correctly, if you want to use ureq-native-tls
feature, you have to enable ureq-native-tls
feature and also explictly add native-tls
as dependency and set it up?
you have to enable
ureq-native-tls
feature and also explictly addnative-tls
as dependency and set it up?
You have to explicitly pass a native_tls::TlsConnector
instance to AgentBuilder::tls_connector
. native_tls
is provided by the native-tls
crate, so yeah, you have to add native-tls
as a dependency.
Thanks for the contribution :)
Can you please release a new version soon? :)
Yeah, I've released the v0.13.1
Description
Feature
ureq-native-tls
currently doesn't work because ureq requires the TLS connector to be specified explicitly for native-tls:When ncspot is built with rspotify with ureq-native-tls, it's unable to create an HTTPS connection:
Motivation and Context
rspotify currently doesn’t work when built with
ureq-native-tls
.Dependencies
tls-native
(optional)Type of change
Please delete options that are not relevant.
How has this been tested?
CI
Is this change properly documented?
Yes
Related to #402
Fixes hrkfdn/ncspot#1159