Update cache action runner

jrfnl commented 8 months ago

Description

The actions/cache package has released version 4.0 which updates the action runner to use Node 20.

Applying this fix gets rid of the following warning which is currently showing in the "Annotations" of workflows using the ramsey/composer-install action:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Note: most action runners have published these types of update in a new major, so that seems to be the best practice. Not sure if this update warrants a new major for ramsey/composer-install ?

Update: From what I've read, I believe this should be released in a new major as otherwise people using this action in self-hosted runners will run into trouble with this change.

Refs:

Motivation and context

People don't like to see warnings in their workflows ;-)

How has this been tested?

Pre-existing automated tests cover this change and the tests pass.

If you look in your own workflows, you can see that without this change, the following annotations (and a dozen more) display:

Run unclean (ubuntu-latest, v2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Run action (ubuntu-latest, highest, v2, tests/fixtures/out-of-sync-lock)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

With this change, the annotations change to:

Run unclean (ubuntu-latest, v2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Run action (ubuntu-latest, highest, v2, tests/fixtures/out-of-sync-lock)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

For this last warning regarding actions/checkout@v3, PR #248 is already open, so this is not addressed here.

Types of changes

Not sure what to put here, could be seen as just plain maintenance, could also be seen as a breaking change ?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING.md document.
[ ] I have added tests to cover my changes.

Fixes #253 Closes #254

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c49029a) 84.23% compared to head (9fc1be9) 84.23%.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/ramsey/composer-install/pull/252/graphs/tree.svg?width=650&height=150&src=pr&token=ZP54XdHMGI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ben+Ramsey)](https://app.codecov.io/gh/ramsey/composer-install/pull/252?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ben+Ramsey) ```diff @@ Coverage Diff @@ ## v2 #252 +/- ## ======================================= Coverage 84.23% 84.23% ======================================= Files 7 7 Lines 203 203 ======================================= Hits 171 171 Misses 32 32 ```

Levdbas commented 8 months ago

@ramsey , would you like to take a look at this? We are getting a lot of deprecation notices at @timber that would be solved with this update.

jrfnl commented 7 months ago

@ramsey Any chance of movement on this PR ? 🙏🏻

ruudk commented 7 months ago

@ramsey Thanks for the merge, could you please tag it as well? We like to pin it to a specific version.

jrfnl commented 7 months ago

@ramsey Just saw the new tag - but shouldn't this have been a major release as per my comment above ?

Note: most action runners have published these types of update in a new major, so that seems to be the best practice. Not sure if this update warrants a new major for ramsey/composer-install ?

Update: From what I've read, I believe this should be released in a new major as otherwise people using this action in self-hosted runners will run into trouble with this change.