Laravel 6

[tarikhamilton]

The plugin was locked into an old version of illuminate/support in the dependencies.

Description

Updated composer

Motivation and Context

To use Laravel 6

How Has This Been Tested?

Honestly, I haven't. I just looked at the diff. https://github.com/illuminate/support/compare/5.8...6.x

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.
• [ ] I have run composer run test locally, and there were no failures or errors.

[ramsey]

A better approach for the versioning might be to use something like this:

"illuminate/support": "^5.6 | ^6"

Have you tested that this installs and works on Laravel 6?

[ramsey]

It looks like some of the other dependencies will need to be updated, as well.

[tarikhamilton]

@ramsey I updated it to ">5.6", but I can see the advantage of "^5.6 | ^6", I will update. :)

[tarikhamilton]

@ramsey If you are referring to league/oauth2-instagram, I was going to make a PR for that as well. It isn't up to date with Instagram.

[ramsey]

I'm referring to the other dev dependencies of this package, which are causing the builds to fail when using Laravel 6.

[tarikhamilton]

I'm referring to the other dev dependencies of this package, which are causing the builds to fail when using Laravel 6.

They were just PSR12 formatting issues. Updated. :)

And I did test with my Laravel 6 app and authenticated without any issues. But the basic scope no longer exists. They'll want to pass 'scope' => 'user_profile,user_media' in the first param of Instagram::authorize.