Fix \uXXXX codes in composer.json - Githubissues

ramsey / php-library-starter-kit

:building_construction: A tool to quickly set up the base files of a PHP library project.

MIT License

244 stars 25 forks source link

Fix \uXXXX codes in composer.json #2

Closed upyx closed 4 years ago

upyx commented 4 years ago

It fixes #1

Description

It adds a twig escaper for json based on json_encode instead of standard twig js encoder. So a new dependency "ext-json" was added.

Motivation and Context

To fix #1. Because it was really annoying.

How Has This Been Tested?

Unit tests pass. I've created a new project and checked it.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have run composer run test locally, and there were no failures or errors.

ramsey commented 4 years ago

Thank you for contributing! 🎉