ramsey / uuid-doctrine

:snowflake::file_cabinet: Allow the use of a ramsey/uuid UUID as Doctrine field type.
MIT License
892 stars 84 forks source link

Allow doctrine/dbal v4 #242

Closed ruudk closed 6 months ago

ruudk commented 7 months ago

Description

Allow doctrine/dbal v4

Motivation and context

https://github.com/doctrine/dbal/releases/tag/4.0.0

How has this been tested?

Not yet, CI?

Types of changes

PR checklist

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ee0b1ef) 99.27% compared to head (f76168e) 99.27%. Report is 1 commits behind head on main.

:exclamation: Current head f76168e differs from pull request most recent head ddffc49. Consider uploading reports for the commit ddffc49 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ramsey/uuid-doctrine/pull/242/graphs/tree.svg?width=650&height=150&src=pr&token=FVm8VB6YS1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ben+Ramsey)](https://app.codecov.io/gh/ramsey/uuid-doctrine/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ben+Ramsey) ```diff @@ Coverage Diff @@ ## main #242 +/- ## ========================================= Coverage 99.27% 99.27% Complexity 68 68 ========================================= Files 6 6 Lines 138 138 ========================================= Hits 137 137 Misses 1 1 ```
Chris53897 commented 7 months ago

@ruudk Thanks for working on this. Can you please change this line to "doctrine/orm": "^2.5 || ^3.0", to allow the install of dbal 4 ? https://github.com/ramsey/uuid-doctrine/blob/f76168ebe57e7a67a92d9ceeccd91b6174276cec/composer.json#L27

There is some work todo, to make it work with dbal 4.

ruudk commented 7 months ago

Done

Chris53897 commented 7 months ago

It was hard to pass all git hooks prechecks. I did a seperate PR i try to fix some issues. https://github.com/ramsey/uuid-doctrine/pull/245

Chris53897 commented 6 months ago

I did closed my PR in favor of https://github.com/ramsey/uuid-doctrine/pull/247 I think this PR should be closed too