ramv / node-elastical

Node.js client for the ElasticSearch REST API.
MIT License
105 stars 19 forks source link

dot not transform null into {} #3

Closed Filirom1 closed 11 years ago

Filirom1 commented 11 years ago

Curently elastical transform null value into the empty object.

{
  option: null
}

become

{
  option: {}
}

The PR fix this.

ElasticSearch works great with the null value, there is no need to change this behaviour.

feugy commented 11 years ago

Hi there,

I had the same problem few weeks ago, and fix it locally. It will very handy to integrate it.

Thank you !

VirgileD commented 11 years ago

+1

ramv commented 11 years ago

I will take a look today.

On Mon, Nov 19, 2012 at 4:27 AM, virgile devaux notifications@github.comwrote:

+1

— Reply to this email directly or view it on GitHubhttps://github.com/ramv/node-elastical/pull/3#issuecomment-10511712.

Best Regards,

Ram Viswanadha

Filirom1 commented 11 years ago

@ramv is there anything wrong with this Pull Request ?

Filirom1 commented 11 years ago

Thanks

Filirom1 commented 11 years ago

@ramv it would be even better to have it on npm ;)

ramv commented 11 years ago

will try to get it out by the end of the week.

On Wed, Jan 16, 2013 at 2:32 AM, Romain notifications@github.com wrote:

@ramv https://github.com/ramv it would be even better to have it on npm ;)

— Reply to this email directly or view it on GitHubhttps://github.com/ramv/node-elastical/pull/3#issuecomment-12312638.

Best Regards,

Ram Viswanadha

ramv commented 11 years ago

Hi Romain, pushed out a new version of Node Elastical.

On Wed, Jan 16, 2013 at 7:22 AM, Ram Viswanadha rviswanadha@gmail.comwrote:

will try to get it out by the end of the week.

On Wed, Jan 16, 2013 at 2:32 AM, Romain notifications@github.com wrote:

@ramv https://github.com/ramv it would be even better to have it on npm ;)

— Reply to this email directly or view it on GitHubhttps://github.com/ramv/node-elastical/pull/3#issuecomment-12312638.

Best Regards,

Ram Viswanadha

Best Regards,

Ram Viswanadha

Filirom1 commented 11 years ago

Perfect

Le lundi 28 janvier 2013, Ram Viswanadha a écrit :

Hi Romain, pushed out a new version of Node Elastical.

On Wed, Jan 16, 2013 at 7:22 AM, Ram Viswanadha <rviswanadha@gmail.com<javascript:_e({}, 'cvml', 'rviswanadha@gmail.com');>>wrote:

will try to get it out by the end of the week.

On Wed, Jan 16, 2013 at 2:32 AM, Romain <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>> wrote:

@ramv https://github.com/ramv it would be even better to have it on npm ;)

— Reply to this email directly or view it on GitHub< https://github.com/ramv/node-elastical/pull/3#issuecomment-12312638>.

Best Regards,

Ram Viswanadha

Best Regards,

Ram Viswanadha

— Reply to this email directly or view it on GitHubhttps://github.com/ramv/node-elastical/pull/3#issuecomment-12769028.