search

ramv / node-elastical

Node.js client for the ElasticSearch REST API.
MIT License
105 stars 19 forks source link

Implemented getSettings #4

Closed jazzzz closed 11 years ago

ramv commented 11 years ago

Hi Jazzzz, thanks for the pull. There are no tests in the pull request. Can you please add them?

jazzzz commented 11 years ago

Before adding tests, I would like the current ones to pass. I'm working on Windows XP and ElasticSearch 0.19.11, is there something incompatible with the tests in my configuration?

WARNING! The online tests will delete ALL ElasticSearch indices on
localhost to ensure a clean testing environment.

Do you want to continue and delete all indices? (yes/no): yes
node_modules/.bin/vows tests/online-tests.js
????·??·····???·???????????··???·???·?·?·?··? Errored » 15 honored  29 broken  1 errored

Makefile:14: recipe for target `online-tests' failed
make: [online-tests] Error 1 (ignored)
jazzzz commented 11 years ago

I found the issue: a bad proxy env var curl was using to connect to elastic search.

ramv commented 11 years ago

cool. Any update on the tests?

jazzzz commented 11 years ago

@ramv did you have some time to check the tests?