search

ranahanocka / MeshCNN

Convolutional Neural Network for 3D meshes in PyTorch
MIT License
1.58k stars 316 forks source link

Defining boundary edges in the code #17

Closed amanjain1397 closed 5 years ago

amanjain1397 commented 5 years ago

has_boundaries

Hi Rana,

If I am not wrong, the function has_boundaries determines whether an edge is a boundary edge or not. So why are we checking the connectivity of the adjacent edges of a given edge (having edge_id = edge_id)?

ranahanocka commented 5 years ago

Hi @amanjain1397 ,

we used has_boundaries to check if any edges "nearby" are boundaries. We didn't want to collapse edges which have boundaries in their 1-ring, since these cases are complicated and can cause non-manifold geometries to occur. For example, this edge is not a boundary edge: image but there are boundaries in it's 1-ring. And collapsing it results in a non-manifold vertex.

amanjain1397 commented 5 years ago

Thanks for the clarification, Rana.