search

ranahanocka / MeshCNN

Convolutional Neural Network for 3D meshes in PyTorch
MIT License
1.56k stars 314 forks source link

No edge_groups union in __remove_triplete? #97

Open DandiC opened 3 years ago

DandiC commented 3 years ago

Hi Rana,

I have a question about the unpooling outcome when __remove_triplete is called during pooling. I noticed that in this case, you don't call MeshPool.__union_groups when removing the edges. From my understanding of the code, this means that when they are reconstructed, their features will not be computed by doing the average of their neighbor features. Is this correct? If so, could you share the reasons behind this choice and what is the outcome when these invalid edges are "unpooled"?

Thanks!

DandiC commented 3 years ago

I just realized that __union_groups is actually called in get_invalids(). However, I am a little confused about what exactly is going on there. If you can clarify a little about it I would greatly appreciate it :)