search

ranaparamveer / android-sqlite-asset-helper

An Android helper class to manage database creation and version management using an application's raw asset files
Apache License 2.0
25 stars 3 forks source link

Cleaner git history #2

Open Kisty opened 6 years ago

Kisty commented 6 years ago

Hi @ranaparamveer. Thanks for taking over this project. Really appreciate it!

I'm a bit concerned though with the history of changes. Having all the PRs rolled into the commit called Updated the build tools version and android sdk versions. doesn't explain in the message those changes. If I were you, I'd merge the PRs as single commits so that it looks a bit clearer. Also, the recent commits are duplicated and it looks a bit messy. Now changing git history once it's published is a bit messy but perhaps we could try and work together to make a cleaner history. Take a look at https://github.com/InflationX/Calligraphy/commits/master history. It's clear what the changes are and easier to read.

If you'd like, I can try and make the history a bit cleaner and see what you think. As I said, changing git history is hard but it's doable. Remember when you're committing code locally, you can change it as much as you like. But when you push changes to the server, you need to think twice about it. See http://justinhileman.info/article/git-pretty/git-pretty.png. Using git commit --amend can edit the last commit and other things you can do to clean up history before you push it.

I hope this helps and that you don't take it personally, it's just that I think we could do it better.

ranaparamveer commented 6 years ago

Thanks for pointing this out. I also agree with your concern. I'll definitely ask for your help once i start doing cleanup. Most probably i'll start with the process on coming weekend.

ranaparamveer commented 5 years ago

Hi @Kisty, Please let me know your availability in guiding me through cleanup process.