Minor change allows matplotlib to display plots, closes #320.

ranaroussi / quantstats

Portfolio analytics for quants, written in Python

Apache License 2.0

4.82k stars 841 forks source link

Minor change allows matplotlib to display plots, closes #320. #321

Open git-shogg opened 10 months ago

git-shogg commented 10 months ago

Hi Ran, this PR is to enable matplotlib to display plots when the show argument is set to true, previously the functionality was set so that the script execution was not interrupted by plots however, I feel if the user is setting show=True then we should interrupt execution to display the plots? What do you think? This closes #320.

    if show:
        _plt.show(block=True)

    _plt.close()

grzesir commented 8 months ago

Since this library no longer seems to be maintained, we have created a duplicate of it that we plan to maintain and improve over time. If you'd like to use our version check it out here: https://github.com/Lumiwealth/quantstats_lumi

Please feel free to fork and send your pull request to this new library, we will be actively monitoring the library and approving PRs