ranaroussi / quantstats

Portfolio analytics for quants, written in Python
Apache License 2.0
4.59k stars 809 forks source link

Respect boolean parameter ylabel (disable when False) #327

Open alexcalligraphy opened 6 months ago

alexcalligraphy commented 6 months ago

Currently, the parameter =ylabel= is ignored and the hard-coded ylable is written regardless of the =ylabel= parameter is truthy or falsy.

This change will not set an ylable for the chart if the =ylabel= parameter is set to a falsy value.

In a next step one could check if =ylable= is a String and if so, set the actual ylable string to that string.

grzesir commented 5 months ago

Since this library no longer seems to be maintained, we have created a duplicate of it that we plan to maintain and improve over time. If you'd like to use our version check it out here: https://github.com/Lumiwealth/quantstats_lumi

Please feel free to fork and send your pull request to this new library, we will be actively monitoring the library and approving PRs