search

ranbuch / accessibility

add accessibility to your website
MIT License
287 stars 35 forks source link

it loads fonts / icons #38

Closed SorinSu closed 3 months ago

SorinSu commented 1 year ago

hi,

it looks good, but unfortunately it loads external fonts which nowadays may cause massive problems because of GDPR.

Any plans to change this?

ranbuch commented 1 year ago

Hi @SorinSu ,

You can initiate the instance like this:

new Accessibility({ icon: { useEmojis: true } });

Hope this helps.

fabiojust commented 1 year ago

Hi @ranbuch , great work. I'm using your plugin in Joomla; for the same problem of @SorinSu i want to charge Material Icons locally. It seams to be possible but the plugins open the online source googleapis anyway. Can you help me?

ranbuch commented 1 year ago

Thanks @fabiojust , we need to allow loading the material icons font from other locations as well as the default google fonts.

Reopening this issue, don't know when I'll be able to implement this behavior.

mustafauysal commented 4 months ago

I've opened a PR that replaces Google Fonts with Bunny Fonts. It might be easier to use since it's a drop-in replacement and there's not much to do.

Also, +1 for allowing fonts to be loaded from other locations.

ranbuch commented 3 months ago

@SorinSu @fabiojust Please see this issue that includes a fix for the problem.