search

rancher-plugins / rancher-machine-driver-oci

Oracle Cloud Infrastructure Driver Plugin for (Rancher) Docker Machine
Apache License 2.0
7 stars 8 forks source link

Node name prefix #12

Closed mrcsilva closed 2 years ago

mrcsilva commented 2 years ago

Is there any particular reason the node driver has a defaultNodeNamePfx for each node?

Thanks!

jlamillan commented 2 years ago

I don't believe there was a functional reason for it, no. The prefix was more about making it easier to identify which instances were created by the docker-machine.

jlamillan commented 2 years ago

Node name prefix removed in version v1.2.0

mrcsilva commented 2 years ago

Oh, got it. However, I think Rancher already assigns a name to the machine based on the node pool name.

Thank you for the quick fix!