Closed PatrickLaabs closed 2 months ago
Describe the solution you'd like: Using the ClusterAPIs ClusterResourceSets, we can use the Rollout-Strategy 'Reconcile'.
The documentation can be found here: https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-resource-set#update-from-applyonce-to-reconcile
Why do you want this feature: Currently, the CAPHV ClusterAPI Provider only provides the ClusterResourceSets with the Rollout-Strategy of: strategy: ApplyOnce.
strategy: ApplyOnce
Like here: https://github.com/rancher-sandbox/cluster-api-provider-harvester/blob/4fe74d12e8790ffe838cd25403048d4d721c8660/templates/cluster-template-rke2.yaml#L147-L160
When a User/Admin deletes a ClusterResourceSet, the CRS will not be reconciled to the cluster, when using the ApplyOnce option.
ApplyOnce
Instead, we should move to the Strategy of: strategy: Reconcile
strategy: Reconcile
By doing this, we include a little bit more robustness to the ClusterResourceSets and ensure the availability on the clusters attached.
Describe the solution you'd like: Using the ClusterAPIs ClusterResourceSets, we can use the Rollout-Strategy 'Reconcile'.
The documentation can be found here: https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-resource-set#update-from-applyonce-to-reconcile
Why do you want this feature: Currently, the CAPHV ClusterAPI Provider only provides the ClusterResourceSets with the Rollout-Strategy of:
strategy: ApplyOnce.Like here: https://github.com/rancher-sandbox/cluster-api-provider-harvester/blob/4fe74d12e8790ffe838cd25403048d4d721c8660/templates/cluster-template-rke2.yaml#L147-L160
When a User/Admin deletes a ClusterResourceSet, the CRS will not be reconciled to the cluster, when using the
ApplyOnceoption.Instead, we should move to the Strategy of:
strategy: ReconcileBy doing this, we include a little bit more robustness to the ClusterResourceSets and ensure the availability on the clusters attached.
Anything else you would like to add: