The way of referencing existing resources in harvester should work equally.

rancher-sandbox / cluster-api-provider-harvester

A Cluster API Infrastructure Provider for Harvester

Apache License 2.0

21 stars 6 forks source link

The way of referencing existing resources in harvester should work equally. #6

Closed firecyberice closed 6 months ago

firecyberice commented 7 months ago

The ssh KeyPair needs to be in the desired vm namespace. https://github.com/rancher-sandbox/cluster-api-provider-harvester/blob/07d0b61f34a8277c0b8eac620dcd52e757e14b5b/samples/kubeadm/example.yaml#L133

On the other side the used image can specify a namespace and the image name in the form NAMESPACE/IMAGENAME

https://github.com/rancher-sandbox/cluster-api-provider-harvester/blob/07d0b61f34a8277c0b8eac620dcd52e757e14b5b/README.md?plain=1#L96

belgaied2 commented 7 months ago

@firecyberice you are absolutely right. The sshKeyPair should also offer the flexibility of choosing another namespace. I will work on that soon.

belgaied2 commented 6 months ago

Fixed in b807130.

Now the behaviour for all of the following fields is that they will accept both / and (the latter will use HarvesterCluster.Spec.TargetNamespace as a namespace.):

harvestercluster.spec.loadBalancerConfig.ippool.vmnetwork
harvestermachine.spec.sshKeyPair
harvestermachine.spec.networks
harvestermachine.spec.volumes.imageName

@firecyberice Please let me know if there is anything not working correctly. And thank you for your contributions.