search

rancher-sandbox / cluster-api-provider-harvester

A Cluster API Infrastructure Provider for Harvester
Apache License 2.0
21 stars 6 forks source link

Use variable names for the vm counts like described in cluster-api #7

Closed firecyberice closed 6 months ago

firecyberice commented 7 months ago

Please use the same environment variables like all other providers (or at least how they are named in clusterctl) https://github.com/rancher-sandbox/cluster-api-provider-harvester/blob/07d0b61f34a8277c0b8eac620dcd52e757e14b5b/README.md?plain=1#L97-L98

While clusterctl uses this clusterctl generate cluster --control-plane-machine-count --worker-machine-count and the variables are named like shown here: https://github.com/kubernetes-sigs/cluster-api/blob/f335f132714a49adfcd815512c5125d8891f29d6/docs/book/src/clusterctl/provider-contract.md?plain=1#L327-L328

belgaied2 commented 6 months ago

Fixed in 1b50974bd0a40a1e375c87ee1ac2486183303587