rancher-sandbox / cluster-api-provider-rke2

RKE2 bootstrap and control-plane Cluster API providers.
Apache License 2.0
78 stars 24 forks source link

Add ADR explaining removal of kubebuilder defaults #335

Closed alexander-demicev closed 1 month ago

alexander-demicev commented 1 month ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

Danil-Grigorev commented 1 month ago

@salasberryfin Defaults are only evaluated on the first apply, then the applied data is stored in etcd, so all existing manifests should already have user defined values for these fields.

salasberryfin commented 1 month ago

Thanks @Danil-Grigorev.