search

rancher-sandbox / rancher-desktop

Container Management and Kubernetes on the Desktop
https://rancherdesktop.io
Apache License 2.0
6.01k stars 282 forks source link

Windows installer reboots system without prompt/warning #1859

Open jandubois opened 2 years ago

jandubois commented 2 years ago

On a pristine Windows system (both 10 and 11) the setup program installs WSL2 and then asks to reboot.

After the reboot, it does some actions that seem to require a further reboot (upgrade the WSL kernel? why don't we install WSL2 with the latest?). There is no prompt before the second reboot, which makes it feel like a crash or failure.

rak-phillip commented 2 years ago

I think I encountered the same behavior. Here is my experience when attempting to install on Windows 10 Pro 10.0.19044 Build 19044 with a non-admin user without WSL:

User should be able to install Rancher Desktop on Windows without WSL when running as a non-administrator user

Error Starting Kubernetes
Error: wsl.exe exited with code 4294967295
Last command run:
wsl.exe --import rancher-desktop C:\Users\test_user\AppData\Local\rancher-desktop\distro C:\Users\test_user\AppData\Local\Programs\Rancher Desktop\resources\resources\win32\distro-0.20.tar --version 2

Context:
Starting Kubernetes

Some recent logfile lines:
2022-03-21T21:05:33.880Z: Registered distributions: 
2022-03-21T21:05:33.947Z: Registered distributions: 
2022-03-21T21:05:34.007Z: Registered distributions: 
2022-03-21T21:05:34.213Z: WSL failed to execute wsl.exe --import rancher-desktop C:\Users\test_user\AppData\Local\rancher-desktop\distro C:\Users\test_user\AppData\Local\Programs\Rancher Desktop\resources\resources\win32\distro-0.20.tar --version 2: Error: wsl.exe exited with code 4294967295
Error Starting Kubernetes
TypeError: t is not iterable
Last command run:
wsl --import rancher-desktop C:\Users\test_user\AppData\Local\rancher-desktop\distro C:\Users\test_user\AppData\Local\Programs\Rancher Desktop\resources\resources\win32\distro-0.19.tar --version 2

Context:
Starting Kubernetes

Some recent logfile lines:
    at Y.readCache (C:\Users\test_user\AppData\Local\Programs\Rancher Desktop\resources\app.asar\dist\app\background.js:1:10517)
    at async C:\Users\test_user\AppData\Local\Programs\Rancher Desktop\resources\app.asar\dist\app\background.js:2:13553
2022-03-21T21:11:33.890Z: Running command wsl --list --quiet...
2022-03-21T21:11:34.161Z: Registered distributions: 
2022-03-21T21:11:34.166Z: Running command wsl --list --quiet...
2022-03-21T21:11:34.214Z: Registered distributions: 
2022-03-21T21:11:34.214Z: Running command wsl --list --quiet...
2022-03-21T21:11:34.261Z: Registered distributions: 
2022-03-21T21:11:34.261Z: Running command wsl --import rancher-desktop C:\Users\test_user\AppData\Local\rancher-desktop\distro C:\Users\test_user\AppData\Local\Programs\Rancher Desktop\resources\resources\win32\distro-0.19.tar --version 2...
jandubois commented 2 years ago

@rak-phillip The attempt to launch after the first reboot triggered the "update" from 1.2-RC1 to 1.1.1, which then failed to start. You can see that the initial error is about importing distro-1.20, but the second error is trying to load distro-1.19.

This should not happen for released versions because there should be no update available for the latest released version.

None-the-less, this is still terrible UX and should be improved!

rak-phillip commented 2 years ago

Looks like you are correct, thanks for digging into that one. A tad unexpected and I'm curious how 1.1.1 gets introduced without any action on my end.. With that being the case, the logs I posted probably aren't relevant to this issue.

jandubois commented 2 years ago

I'm curious how 1.1.1 gets introduced without any action on my end

This is auto-update in action. 1.1.0-258 is semantically earlier than 1.1.1, so will pick up the latter from the upgrade server.

I'm going to hide all of these comments, as they are unrelated to the actual issue.